Frontend review hygiene
Skill krkrkrr/skills/skills/frontend/frontend-review-hygiene
Use when assessing code quality hygiene — TypeScript strictness, lint violations, dead code, and duplication. Runs `audit-typescript.sh`, `audit-lint.sh`, `audit-similarity.sh`. Does NOT cover dependency freshness or CVE audit — use `frontend-review-deps` for that.From its SKILL.md
npx -y skills add krkrkrr/skills --skill frontend-review-hygieneAssembled from the repository path, not quoted from the project. Check it against their README if it does not work.
2 things to look at
- no licenseNo license file was found in the repository. Code published without one is not open source by default, so using it at work is a question for whoever answers licensing questions where you are.
- 0 stars0 stars. Stars are a popularity signal and not a quality one, but at this level it is likely that nobody has read this closely except its author, and you would be relying on your own review.
What its file declares
Copied from the file, not written here
The file declares its own license as MIT. That is the author’s claim about this one file, and it is not the same thing as the license GitHub reports for the repository, which is listed with the other numbers below.
SKILL.md
2.8 KB, 638 tokens by cl100k_base, as published. Nobody here has run it
Frontend Review — Hygiene
You are assessing the baseline code quality hygiene of a frontend project: types, lint, dead code, and duplication. These are the KPIs that will be ratcheted each week.
Procedure
- In parallel, run:
scripts/audit-typescript.sh --repo <client-repo>scripts/audit-lint.sh --repo <client-repo>scripts/audit-similarity.sh --repo <client-repo>
- Read each
raw/*.json. - Compare with the previous run if
<client-repo>/.frontend-review/kpi/baseline.jsonexists.
Output
Write <client-repo>/.frontend-review/report/latest/md/hygiene-summary.md with:
- KPI table covering:
anycount,@ts-ignorecount, lint errors/warnings, knip unused files/exports/deps, similarity duplicate pairs - Delta vs baseline (mark regressions in bold; improvements with ✅)
- Remediation batches grouped by impact — which items make sense to fix in one PR
- Do NOT include per-file findings (those stay in the raw JSON). The report is for decisions, not code review.
If the client has no baseline yet, create one: copy the current JSON to <client-repo>/.frontend-review/kpi/baseline.json and state this in the report.
Toolchain Role Separation
When assessing the linting / formatting stack, check for clear role boundaries:
| Tool | Intended role |
|---|---|
| TypeScript | Type correctness only |
| ESLint / Biome / oxlint | AST-level bug patterns, import rules |
| Prettier / Biome / oxfmt | Formatting only — no overlap with linting |
| ast-grep / custom rules | Project-specific structural rules |
| vitest / jest | Behaviour |
Overlapping responsibilities (e.g., ESLint also handling formatting) cause conflicts and slower CI. Flag and recommend separation.
Auto-generated files (lock files, generated schemas, tool artefacts) must be excluded from formatting runs. Repeatedly formatting and reverting a generated file is a signal they are missing from .prettierignore / .biomeignore / equivalent.
Boundaries
- Do NOT assess dependency freshness or CVEs — that's
frontend-review-deps. - Do NOT propose code-level fixes. That's for the 5 perspective skills.
- Do NOT touch source files in the client repo.
- Do NOT run
audit-security.sh— that's the security skill's job.
Reference
- Checklist:
03-typescript.md,04-lint-format.md,05-deadcode-knip.md,06-similarity.md,13-kpi-tracking.md - Related:
frontend-review-deps(dependency health),frontend-review-security(CVEs + auth + env) - Phase:
week-1-ci-baseline.md,week-4-ai-review.md