Pr review

Review PR

Dispatch PR review, address feedback, and comment on the PR.

Prerequisite: A PR created by /pr-create.

Review principle: Verify each suggestion against the codebase before implementing. Push back on incorrect ones with technical reasoning — no performative agreement.

Workflow

Step 1: Setup

Identify the PR from argument, current branch (gh pr view), or gh pr list --author @me --state open. If multiple candidates, ask the user. Store PR number, branch, URL.

Detect: BASE_BRANCH from gh pr view --json baseRefName, DEFAULT_BRANCH from refs/remotes/origin/HEAD (fallback for BASE_BRANCH), MAIN_REPO from git rev-parse --path-format=absolute --git-common-dir (strip /.git), IS_WORKTREE (git-dir differs from git-common-dir), WORKTREE_PATH from git worktree list matching branch.

If not on PR branch: use existing worktree if found (cd into it), otherwise gh pr checkout.

Step 2: Mode Selection

If --automated-fix/-A passed, use automated-fix mode. If --automated-merge/-M passed, use automated-merge mode. If --deliberate/-D passed, use deliberate mode (skip the settings lookup and prompt below). More than one mode flag together is invalid — fail fast. Either automated flag + --skip-fixes is also invalid — fail fast.

If no mode flag, read the user's preference:

mode=$(caliper-settings get review_mode)

• If a mode is returned (automated-fix, automated-merge, or deliberate): the user explicitly configured this. Use it.
• If PROMPT_REQUIRED: no explicit preference — use AskUserQuestion to ask:
  • Automated fix — Fix all actionable findings without interaction.
  • Automated merge — Fix all actionable findings, then auto-merge the PR.
  • Deliberate — Collect all feedback, present unified triage, choose what to fix.

Step 3: Rebase onto Base Branch

git fetch origin
if ! git merge-base --is-ancestor origin/$BASE_BRANCH HEAD; then
  git rebase origin/$BASE_BRANCH
  git push -u origin HEAD --force-with-lease
fi

Use bare git fetch origin (no branch arg) so the remote-tracking ref refs/remotes/origin/$BASE_BRANCH actually advances. git fetch origin $BASE_BRANCH only updates FETCH_HEAD, leaving origin/$BASE_BRANCH stale — which silently widens the reviewer's diff scope when other PRs merge during the session.

If rebased, log it. If conflicts, stop and ask user. After force-push, only process comments posted after the push timestamp (or wait for fresh bot comments).

Step 4: Dispatch Subagent in Background

Skip if --skip-review passed or caliper-settings get skip_review returns true.

Read PR reviewer model: caliper-settings get pr_reviewer_model — substitute into reviewer-prompt.md's model: field.

Read reviewer-prompt.md and dispatch with run_in_background: true:

• {DIFF_RANGE} = origin/$BASE_BRANCH...HEAD (three-dot — merge-base diff, matches GitHub's PR view; two-dot includes phantom-reverts of base commits when the branch is behind)
• {REPO_PATH} = repository root
• {PR_NUMBER} = PR number
• {HEAD_SHA} = git rev-parse HEAD — anchors the review to the exact commit the subagent saw, so line numbers stay valid even if anything pushes during the background window

Subagent posts findings as inline review comments via the GitHub reviews API, then returns the Findings table (with each finding's Comment ID) for Step 6.

Replying to reviewer findings

When you decide a subagent finding's disposition (fix or dismiss), reply in its own thread so the back-and-forth lives where the issue was raised — not only in the Step 9 summary. Reply by the Comment ID from the returned table:

gh api "repos/{owner}/{repo}/pulls/$PR_NUMBER/comments/$COMMENT_ID/replies" \
  -f body="Fixed in $(git rev-parse --short HEAD) — <what changed>."
# or: -f body="Dismissed — <technical reasoning>."

These are your own ($GH_USER) comments — replying to them is intended, and is separate from the Step 5 self-filter, which only prevents re-ingesting findings. Findings with Comment ID = — (body-only) have no thread; they go in the Step 9 summary instead. Post each reply where the disposition is finalized: Step 6 (automated) or Step 8 (deliberate).

Step 5: External Feedback

Wait for bots:

• --automated-merge from orchestrate: wait 90s, then poll every 30s.
• User-selected automated (fix or merge): wait 60s warm-up, then poll every 60s.
• Deliberate: no warm-up, poll every 60s.
• Each poll queries gh pr checks AND all three feedback sources below (conversation comments, REST inline comments, reviews). Green checks alone don't mean bots are done: review bots like Gemini (gemini-code-assist) register no CI check and post no in-progress marker — their review simply appears as inline comments a few minutes after the PR opens. If the repository is known to use review bots (or any bot activity is detected on the PR), keep polling until the timeout elapses, treating it as ready sooner only once every known review bot has posted (a review, or an explicit skip/paused comment like CodeRabbit's integrate/* skip). If no review bots are used or active, proceed once standard CI checks complete.
• Bot rate-limit warning = treat as ready.
• Timeout: caliper-settings get review_wait_minutes (default: 5).

Collect from all three sources, dropping self-authored entries. The Step 4 reviewer subagent runs under the same gh identity as the parent and posts to sources 2-3, so re-ingesting its own findings would double-count against the Findings table returned in Step 6. Capture the identity once, then filter:

GH_USER=$(gh api user -q .login)

1. Conversation comments: gh pr view --json comments
2. Inline review comments: gh api repos/{owner}/{repo}/pulls/$PR_NUMBER/comments
3. Reviews: gh pr view --json reviews

The author field shape differs by API — gh pr view --json reshapes to .author.login (sources 1 and 3), while the raw REST endpoint uses .user.login (source 2). Filter with a fallback so one expression works on all three:

jq --arg me "$GH_USER" '[.[] | select((.user.login // .author.login) != $me)]'

After filtering, sources 2-3 are bot-only.

Categorize:

Category	Action
Actionable — bug, security, correctness	Fix
Suggestion — style, refactor	Fix if improves code, dismiss with reason if not
Informational — praise, explanation	Acknowledge
False positive	Dismiss with reasoning

Automated (fix or merge): Fix actionable items, run tests. If --skip-review (no wave 2): commit and push. Otherwise: commit locally only (wave 2 may touch same files).

Deliberate: Collect and report. No fixes yet.

Step 6: Subagent Results

Wait for background subagent (Step 4). Skip if --skip-review.

Automated (fix or merge): Dismiss findings already fixed in wave 1. Fix remaining actionable items, run tests, commit and push (covers both waves). Reply inline to each subagent finding's thread with its disposition (see Replying to reviewer findings).

Deliberate: Merge with Step 5 findings into unified set. Proceed to Step 7.

Step 7: Present & Confirm (Deliberate Only)

Show summary table (source, category, action, counts). AskUserQuestion:

• Fix all — actionable + suggestions
• Fix critical only — bugs, security, correctness
• Skip fixes — jump to Step 9
• Other — custom instructions

Step 8: Fix, Test, Push (Deliberate Only)

Skip if --skip-fixes. Fix each item, run tests (fail = stop), commit and push. Reply inline to each subagent finding's thread with its disposition (see Replying to reviewer findings).

Step 9: Comment on PR

Post gh pr comment: what was fixed, dismissed (with reasons), no-action. Omit empty sections. Subagent findings answered inline (Step 6/8) need only a roll-up count here, not a re-listing — the per-item reasoning lives in their threads. The summary still fully covers external feedback and any body-only findings that had no thread.

Report PR URL and item counts. Automated-merge mode: invoke pr-merge. Automated-fix mode: tell user to run /pr-merge when ready. Deliberate mode: offer merge or tell user to run /pr-merge when ready.

Arguments

Arg	Effect
<PR number>	Target specific PR
(none)	Detect from current branch
--skip-review / -R	Skip subagent review (Steps 4, 6)
--skip-fixes / -S	Skip fixing — just comment (invalid with automated modes)
--automated-fix / -A	Fix all actionable, no interaction
--automated-merge / -M	Fix all actionable, then auto-merge
--deliberate / -D	Force deliberate mode — skip settings lookup and prompt

Pitfalls

Mistake	Why
Blindly implementing suggestions	Verify against codebase, push back on incorrect ones
Skipping PR comment	Always post what was addressed
Pushing between wave 1 and 2	Wave 1 commits locally, wave 2 pushes

Integration

Preceded by: pr-create | Followed by: pr-merge