Receiving code review
How to answer a reviewer - verify each suggestion against the code before acting on it, push back with technical reasoning when the reviewer is wrong, and treat "implement this properly" as a question about scope. Triggers whenever review feedback arrives, during Verify and on any pull request.From its SKILL.md
npx -y skills add jed72/compass --skill receiving-code-reviewAssembled from the repository path, not quoted from the project. Check it against their README if it does not work.
One thing to look at
- 1 stars1 stars. Stars are a popularity signal and not a quality one, but at this level it is likely that nobody has read this closely except its author, and you would be relying on your own review.
SKILL.md
2.2 KB, as published. Nobody here has run it
Receiving Code Review
There are two ways to answer a reviewer badly, and agreeing too readily is the more common one.
Verify each suggestion against the code before you implement it. Every comment is a hypothesis about code the reviewer read faster than you wrote it. A suggestion right about the smell and wrong about the cause is the normal case - implementing it verbatim leaves the smell and adds a change nobody needed.
"You're absolutely right", before checking, is the failure this prevents. It converts the reviewer's guess into your commit, removing the second opinion review existed to give.
Push back with technical reasoning when the reviewer is wrong. Show the case their suggestion breaks, the constraint it misses, or the measurement that contradicts it - not preference, not seniority, not how long the current version took. If you cannot produce a technical reason, they are probably right.
Treat "implement this properly" as a question about scope. Ask what breaks today without it. If the answer is nothing, it is a separate issue, not a review thread.
Read the label first (S12). Issue, suggestion, nitpick, question or
praise tells you what blocks the merge before you read the argument. If it is
missing, ask rather than guess.
Say what you did. Per comment: changed it, or did not and why. A resolved
thread with no reply is a decision nobody can audit, and a change with no
recorded reason is an assertion. Keep the reply short: "Checked -
validate() runs before the cache write, so that race cannot happen here. It
can on the batch path; fixed there."
Anti-patterns
- Reflexive agreement - implementing without checking.
- Reflexive defence - explaining why the code is fine before reading properly.
- Silent compliance - changing it with no reply, so the reasoning is lost.
- Deferring on authority - the code does not know who filed the comment.