Api and interface design
Skill GuillemRoca/agent-skills-android/skills/api-and-interface-design
Production-grade engineering skills for AI coding agents tailored to Android
npx -y skills add GuillemRoca/agent-skills-android --skill api-and-interface-designAssembled from the repository path, not quoted from the project. Check it against their README if it does not work.
One thing to look at
- 2 stars2 stars. Stars are a popularity signal and not a quality one, but at this level it is likely that nobody has read this closely except its author, and you would be relying on your own review.
What its author says it does
Copied from the file, not written here
Use when designing interfaces between layers (Repository, UseCase, API client) or defining data contracts. Covers Retrofit interfaces, Room DAOs, Kotlin sealed classes, and backward compatibility.
SKILL.md
7.9 KB, as published. Nobody here has run it
API and Interface Design
Overview
Hyrum's Law: "With a sufficient number of users of an API, all observable behaviors of your system will be depended on by somebody." Design interfaces — Repository contracts, UseCase signatures, Retrofit services, Room DAOs — as deliberate contracts. Everything observable becomes a dependency.
When to Use
- Defining a new Repository interface
- Creating Retrofit API service interfaces
- Designing Room DAOs
- Defining ViewModel ↔ UI contracts (UiState, Events)
- Changing any public interface in a shared module
- Designing inter-module contracts in multi-module projects
Skip when: Modifying internal (private) implementation details.
Core Process
Step 1: Contract-First Design
- Define the interface before implementing:
// Repository contract (in :core:domain)
interface TaskRepository {
fun getTasks(): Flow<List<Task>>
fun getTaskById(taskId: String): Flow<Task?>
suspend fun createTask(title: String, description: String?): Task
suspend fun updateTask(task: Task)
suspend fun deleteTask(taskId: String)
suspend fun syncWithRemote()
}
- Design principles:
- Return
Flowfor observable data (notsuspendfor single reads) - Use
suspendfor one-shot operations - Accept domain types, not framework types (no
Entityin interfaces) - Throw domain-specific exceptions, not framework exceptions
- Return
Step 2: Retrofit Interfaces
- Define clean API contracts:
interface TaskApi {
@GET("tasks")
suspend fun getTasks(
@Query("page") page: Int = 1,
@Query("per_page") perPage: Int = 20,
): TaskListResponse
@GET("tasks/{id}")
suspend fun getTask(@Path("id") taskId: String): TaskResponse
@POST("tasks")
suspend fun createTask(@Body request: CreateTaskRequest): TaskResponse
@PUT("tasks/{id}")
suspend fun updateTask(
@Path("id") taskId: String,
@Body request: UpdateTaskRequest,
): TaskResponse
@DELETE("tasks/{id}")
suspend fun deleteTask(@Path("id") taskId: String)
}
- API contract rules:
- Use
@Serializabledata classes for request/response bodies (Kotlin Serialization) - Separate request and response models (even if fields overlap)
- Use
sealed classfor polymorphic responses - Never expose Retrofit internals (no
Response<T>in Repository interface)
- Use
Step 3: Data Models and Sealed Types
- Use the type system to make illegal states unrepresentable:
// BAD: stringly-typed status
data class Task(
val id: String,
val title: String,
val status: String, // "pending", "in_progress", "completed" — typos possible
)
// GOOD: sealed type
data class Task(
val id: String,
val title: String,
val status: TaskStatus,
)
sealed interface TaskStatus {
data object Pending : TaskStatus
data object InProgress : TaskStatus
data class Completed(val completedAt: Instant) : TaskStatus
}
- Use value classes for type safety:
@JvmInline
value class TaskId(val value: String)
@JvmInline
value class UserId(val value: String)
// Prevents accidentally passing a UserId where a TaskId is expected
suspend fun getTask(taskId: TaskId): Task
Step 4: Error Handling Strategy
- Define domain-specific errors:
sealed interface DataError {
data class Network(val cause: Throwable) : DataError
data class NotFound(val id: String) : DataError
data class Validation(val message: String) : DataError
data object Unauthorized : DataError
data class Unknown(val cause: Throwable) : DataError
}
// Use Result type for operations that can fail
suspend fun createTask(title: String): Result<Task>
// Or define a custom Result type
sealed interface DataResult<out T> {
data class Success<T>(val data: T) : DataResult<T>
data class Error(val error: DataError) : DataResult<Nothing>
}
- Error handling rules:
- Catch specific exceptions, not generic
Exception - Map framework exceptions to domain errors at the boundary
- Never swallow errors silently
- Provide actionable error messages for the UI
- Catch specific exceptions, not generic
Step 5: Backward Compatibility
- Extend, don't modify:
// Version 1
interface TaskRepository {
fun getTasks(): Flow<List<Task>>
suspend fun createTask(title: String): Task
}
// Version 2: ADD new methods, don't change existing signatures
interface TaskRepository {
fun getTasks(): Flow<List<Task>>
suspend fun createTask(title: String): Task
// New: added with default implementation for backward compatibility
fun getTasksByStatus(status: TaskStatus): Flow<List<Task>> =
getTasks().map { tasks -> tasks.filter { it.status == status } }
}
- When breaking changes are necessary:
- Deprecate with
@Deprecatedand replacement guidance - Provide a migration period
- Update all callers in the same PR
- See
deprecation-and-migrationfor the full process
- Deprecate with
Step 6: Naming Conventions
| Element | Convention | Example |
|---|---|---|
| Repository | get*, observe*, create*, update*, delete* | getTaskById() |
| UseCase | Verb phrase, operator fun invoke() | GetTasksUseCase() |
| Retrofit | HTTP-verb aligned | @GET, @POST, @PUT, @DELETE |
| Room DAO | observe* for Flow, get* for suspend | observeAll(), getById() |
| UiState | Sealed interface per screen | TaskListUiState.Success |
| Events | Past-tense or imperative | TaskClicked, DeleteTask |
| Request/Response | Suffixed | CreateTaskRequest, TaskResponse |
Step 7: Validation at Boundaries
- Validate at system boundaries, trust internally:
// At the API boundary (Retrofit interceptor or repository)
class TaskRepositoryImpl @Inject constructor(
private val api: TaskApi,
private val dao: TaskDao,
) : TaskRepository {
override suspend fun createTask(title: String, description: String?): Task {
// Validate at boundary
require(title.isNotBlank()) { "Task title must not be blank" }
require(title.length <= 200) { "Task title must not exceed 200 characters" }
val entity = TaskEntity(
id = UUID.randomUUID().toString(),
title = title.trim(),
description = description?.trim(),
)
dao.upsert(entity)
return entity.toDomain()
}
}
Common Rationalizations
| Shortcut | Why It Fails |
|---|---|
| "I'll define the interface from the implementation" | Implementation leaks into the contract. Design the contract first. |
| "One model for all layers is simpler" | Coupling DB schema to API to UI makes all three brittle. |
| "Strings are fine for types" | Strings allow typos, have no exhaustiveness checking, and no IDE support. |
| "We don't need backward compatibility yet" | By the time you need it, you have callers you can't easily find. |
Red Flags
- Room entities exposed to UI layer
- Retrofit
Response<T>returned from Repository - Generic
Stringwhere sealed type or enum is appropriate - No validation at system boundaries
- Breaking interface changes without deprecation
AnyorObjectin public interfaces- Inconsistent naming across layers
Verification
- Interfaces designed before implementation (contract-first)
- Domain types used at interface boundaries (not framework types)
- Sealed types used for finite state sets
- Error handling uses domain-specific error types
- Validation at system boundaries, trust internally
- Naming follows project conventions
- Backward compatibility maintained (or breaking change documented)
- Tests verify interface contracts