Pr reviewer

PR Reviewer

No em-dashes. Nothing this skill writes may contain an em-dash; use a comma, colon, or parentheses instead. Enforced by a repo hook that flags em-dashes in generated .md. See /flagrare:write-docs.

Reviews pull requests systematically with full context awareness and humanized feedback.

This skill fetches linked resources via MCP, spawns parallel review subagents for systematic analysis, then synthesises findings into friendly, GitHub-ready comment drafts.

---

When to Use

• User asks to review a PR, code changes, or diff
• User shares a PR link or number
• User asks "review this", "what do you think of these changes", "check this PR"
• User provides a GitHub PR URL

---

Workflow

Step 1: Identify the PR

Parse the PR from user input:

• GitHub URL: extract owner, repo, PR number
• PR number: use current repo context
• Branch name: find associated PR via gh pr list

Fetch the PR details:

gh pr view <number> --json title,body,files,commits,labels,baseRefName,headRefName
gh pr diff <number>

Step 2: Extract and Fetch Linked Resources via MCP

Scan the PR title, description, branch name, and commit messages for linked resources.

Jira/Atlassian tickets:

Extract ticket IDs matching [A-Z]+-[0-9]+ (e.g. SKU-123, CORE-3211).

1. Call getAccessibleAtlassianResources to obtain cloudId
2. For each ticket key, call getJiraIssue with cloudId and issueIdOrKey
3. Use the ticket's summary, description, and acceptance criteria to verify alignment

Figma links:

Extract URLs matching figma.com/design/:fileKey/:fileName?node-id=...

1. Parse fileKey and nodeId (convert - to : in node-id)
2. Call get_design_context with fileKey and nodeId
3. Optionally call get_screenshot for visual reference

Notion docs:

Extract URLs matching *.notion.so/... or *.notion.site/...

1. Call the Notion MCP to fetch page content
2. Use for requirements, API specs, or architecture decisions

If MCP fails:

Note it in the review: "Could not fetch Jira ticket CORE-3211 (Atlassian MCP unavailable). Review based on PR description only." Proceed with available context.

Step 3: Systematic Code Review (parallel subagents)

Spawn five review subagents in parallel using model: "sonnet". Each receives the full PR diff and returns findings.

Do not run these checks sequentially. Spawn all five simultaneously, collect results, then synthesise.

---

Subagent 1: Correctness & Logic

Inputs: full PR diff, PR description, linked ticket acceptance criteria.

For every changed function/method:

• Does the logic match the stated intent (from PR description and ticket)?
• Are there off-by-one errors, missing null checks, unhandled branches?
• Are edge cases covered: empty input, boundary values, error paths?
• Are there race conditions or ordering assumptions?
• Does the change break any existing callers?

---

Subagent 2: Security

Inputs: full PR diff, file list.

Scan for OWASP Top 10 patterns:

• Injection (SQL, command, XSS, template)
• Broken authentication / authorization checks
• Sensitive data exposure (logging secrets, hardcoded keys)
• Missing input validation at system boundaries
• Insecure deserialization
• Overly permissive CORS or CSP
• Dependencies with known vulnerabilities (if lockfile changed)

Only flag issues with concrete exploit paths, not theoretical risks.

---

Subagent 3: Test Coverage & Quality

Inputs: full PR diff (test files and non-test files).

For every behavior introduced or changed:

• Is there at least one test that exercises it through the public API?
• Do tests assert on observable behavior or implementation internals?
• Are test names descriptive of the behavior being tested?
• Missing scenarios: happy path, empty/nil, boundary, error path, idempotency?
• Do tests mock only at genuine external boundaries (network, clock, OS)?
• Testing Trophy shape: more integration tests than unit tests for cross-unit behavior?

---

Subagent 4: SOLID & Architecture

Inputs: non-test source files from the PR diff.

• S: Does any new class/module have more than one reason to change?
• O: Does adding a new variant require modifying existing code?
• L: Does any subtype violate its base type's contract?
• I: Are there fat interfaces forcing unused method implementations?
• D: Are concrete dependencies hardcoded where abstractions would be natural?

Also check: does the change follow the repository's existing architectural patterns, or does it introduce a novel pattern without justification?

---

Subagent 5: Clean Code & Conventions

Inputs: full PR diff, project CLAUDE.md / DEVELOPMENT_GUIDELINES.md (if they exist).

• Magic values without named constants
• Functions doing more than one thing
• Generic unqualified names (data, info, handler, manager)
• Comments that restate the code (keep only "why" comments)
• Half-finished surfaces (TODOs, stub bodies, "implement later")
• Long parameter lists (>3-4 positional params)
• Style violations against project guidelines (if documented)
• Inconsistency with patterns used elsewhere in the same codebase

---

Step 4: Contextual Review (from MCP-fetched resources)

Layer additional review based on the fetched context:

Ticket alignment:

• Do the changes implement what the ticket describes?
• Are all acceptance criteria met?
• Is there scope creep (changes beyond ticket scope)?

Design alignment (if Figma fetched):

• Does the implementation match the design?
• Are spacing, colors, states, and interactions correct?
• Are all design states handled (empty, loading, error, success)?

Doc alignment (if Notion/Confluence fetched):

• Does the implementation match documented specs?
• Are API contracts followed?
• Are architectural decisions respected?

Step 5: Draft Humanized GitHub Comments

For every finding (from both systematic review and contextual review), produce a GitHub-ready comment draft.

Severity scale:

Severity	Symbol	Meaning
Critical	CRITICAL	Must fix before merge: bugs, security, broken behavior
Suggestion	SUGGESTION	Should consider: quality, clarity, maintainability
Nice to have	NICE	Optional improvement

Comment requirements:

• 1-2 sentences max for inline comments
• Copy-paste ready for GitHub
• No AI-isms: avoid "consider", "it would be beneficial", "enhance", "leverage", "crucial", "pivotal"
• Use "you" when it fits
• Frame suggestions as options: "One option:", "Worth adding:", "Might be cleaner to..."
• Reserve firm language for actual blockers only

Voice and examples:

Voice setup. Think of the author as a teammate you respect, someone who's going to read this tomorrow morning before they've had coffee. They already shipped a draft, which took real effort. Write the way you'd actually talk to them at lunch. Usually that means starting from what we noticed rather than what we want done, and asking instead of telling when we're not sure. Use "we" where it fits, since the code is something we share.

Concrete before-and-after pairs. The envelope around each comment (severity, file, line) stays the same; only the comment text shifts. Eight pairs, ordered by severity, then by finding type.

1. Null check (Critical, correctness)

• Cold: `venue` can be null here. Add a safe call or null check.
• Friendly: I think `venue` can come back as null here, in the case where the search doesn't find a match. We hit something similar in BookingRepo a little while ago. Should we add a guard for it?
• What changed: opens with the observation rather than the instruction, frames the codebase as shared, asks instead of commanding.

2. SQL injection (Critical, security)

• Cold: SQL injection risk. Use parameterized queries.
• Friendly: Heads up, looks like `userId` is going straight into the query string here. Should we switch this over to a parameterized version? It's an easy thing to miss in review.
• What changed: warmer opener, asks rather than commands, "easy to miss" removes blame.

3. Test coverage (Suggestion, tests)

• Cold: Missing test for the cancelled path.
• Friendly: Looks like we're already covering the success and reschedule paths, but not cancel. Would be good to lock that one down too if we get a chance.
• What changed: credits existing work first, uses "we" throughout, "if we get a chance" softens the suggestion.

4. Single responsibility (Suggestion, SOLID)

• Cold: This method has too many responsibilities. Extract validation.
• Friendly: I noticed this one's doing both validation and persistence. Pulling validation out into its own function might make the tests easier for us down the line. Totally up to you, though.
• What changed: names the two responsibilities specifically, explains why with "us", explicit "up to you" defuses authority.

5. Missing edge case (Suggestion, correctness)

• Cold: What happens when `items` is empty? Add handling.
• Friendly: I was wondering what happens here if `items` comes through empty. Does the totals calc just zero out, or do we want to throw? Either way is fine, just wanted to make sure whatever we end up with is intentional.
• What changed: poses as a genuine question, offers both options so the author isn't cornered, "we want to" instead of "you should".

6. Generic naming (Suggestion, clean code)

• Cold: `data` is too generic. Rename.
• Friendly: I think this `data` could probably use a more specific name, maybe something like `customerLoyaltyRecord` or whatever fits the actual shape. Future-us would probably thank us when we're grepping for it in six months.
• What changed: "Future-us" is the small but real win. Concrete alternative offered, future-pain rationale frames it as shared.

7. Magic number (Nice, clean code)

• Cold: Replace magic number `86400` with a named constant.
• Friendly: Small thing, but `86400` would probably read more clearly as `SECONDS_PER_DAY`. Takes a beat to recognize it otherwise. Worth pulling out into a constant?
• What changed: "small thing" calibrates severity, admits the inference ("takes a beat"), asks instead of instructs.

8. Convention match (Nice, clean code)

• Cold: Use early return.
• Friendly: Heads up, the rest of `BookingService` is going with early-returns on validation failures. Might be worth doing the same here, just for consistency.
• What changed: references the local convention without claiming authority, "might be worth" hedges.

What the pairs are showing:

• Open with what we noticed, not what we want done.
• First-person voice when we're guessing ("I think", "looks like", "wondering if").
• "We" instead of "you" when the codebase is the subject.
• One short clause of "why" attached to suggestions, not a paragraph.
• Hedges: "probably", "might be worth", "totally up to you", "if we get a chance".
• Severity in the opener: "Heads up" for must-fix, "small thing" or "would be good" for nice-to-haves.

Humanization rules (apply to every comment):

• No em dashes. Use commas, periods, or parentheses.
• No rule of three.
• No "Additionally", "Furthermore", "Moreover".
• No sycophancy ("Great approach!", "Excellent work!").
• Be specific. "Add a null check here" beats "It might be worth considering adding a null check to improve robustness."

Format per finding:

CRITICAL - `path/to/File.kt` L45
GitHub comment: I think `venue` can come back as null here when the search doesn't find a match. Should we add a guard for it?

SUGGESTION - `reservations/BookingService.kt` L32
GitHub comment: I noticed this method's doing a fair bit. Pulling validation out into its own function might make the tests easier for us. Totally up to you.

NICE - `reservations/BookingServiceTest.kt` (file-level)
GitHub comment: Would be good to add a test for the cancelled path too, if we get a chance.

Step 6: Present the Review

## PR Review: <PR title>

### Context Fetched
- Jira: <ticket key> - <summary> (or "not linked" / "MCP unavailable")
- Figma: <file/frame> (or "not linked")
- Notion: <page> (or "not linked")

### Overall Assessment
[One paragraph: what the PR does, whether it aligns with the ticket/design, and the verdict: approve / approve with feedback / needs work]

### Findings

[All findings grouped by file, each with severity and GitHub comment draft]

### Checklist
- [ ] Logic correct and edge cases handled
- [ ] No security issues
- [ ] Tests cover new/changed behavior
- [ ] Code follows project conventions
- [ ] PR description explains what and why
- [ ] Ticket acceptance criteria met
- [ ] Design alignment verified (if applicable)

---

Anti-patterns

• Don't review without fetching linked resources. The ticket and design ARE the spec.
• Don't give vague feedback. "This could be better" is useless. Say what to change.
• Don't nitpick formatting if tooling handles it.
• Don't sound like a checklist or a formal audit.
• Don't post comments to the PR without explicit user approval. Always draft first.
• Don't run subagents sequentially. The whole point is parallel dispatch.

---

Flow position

[PR created or shared]
     |
     v
/flagrare:pr-reviewer
     |--- Step 1-2: fetch PR + linked resources (Jira, Figma, Notion)
     |--- Step 3: 5 parallel subagents (correctness, security, tests, SOLID, clean code)
     |--- Step 4: contextual review (ticket/design/doc alignment)
     |--- Step 5: humanize all findings into GitHub comment drafts
     |--- Step 6: present combined review
     |
     v
[user approves posting or adjusts]