Fp review spec
Validate that E2E_TESTS.md specification files are complete and well-structuredFrom its SKILL.md
npx -y skills add endorhq/flightplanner --skill fp-review-specAssembled from the repository path, not quoted from the project. Check it against their README if it does not work.
One thing to look at
- 6 stars6 stars. Stars are a popularity signal and not a quality one, but at this level it is likely that nobody has read this closely except its author, and you would be relying on your own review.
SKILL.md
2.7 KB, as published. Nobody here has run it
Review E2E Spec
Validate that E2E_TESTS.md specification files are complete, well-structured, and follow the required format. This is a read-only command — it reports findings but does not modify any files.
Additional instructions from the user: "$ARGUMENTS". Ignore if empty.
Phase 1: Discover
- Find all
E2E_TESTS.mdfiles in the project. - Read each one fully.
Phase 2: Validate Structure
For each E2E_TESTS.md, check:
Required elements
- Has an Index section with a markdown link to every suite
- Has at least one suite (H2 heading)
- Every suite has a
### Preconditionssection - Every suite has a
### Featuressection with at least one feature - Features are flat peer headings directly under
### Features— no intermediate category headings (e.g.,#### Core,#### Edge,#### Error). Categories are specified only via<!-- category: ... -->HTML comments. - Every suite has a
### Postconditionssection - Every feature (H4 heading) has at least one assertion bullet
Metadata
- Every feature has a
<!-- category: ... -->comment - Category values are valid:
core,edge,error,side-effect,idempotency - Features with
<!-- skip: ... -->have a documented skip reason
Quality
- No duplicate feature names within a suite
- Preconditions are achievable programmatically (no manual steps)
- Assertions are concrete and testable (not vague like "works correctly")
- Present tense, declarative style ("Creates file" not "Should create file")
Category coverage
For each suite, check that there is reasonable category diversity:
- At minimum,
corefeatures should exist - Warn if no
errorfeatures exist (error handling is often overlooked) - Note if
edgeandidempotencyare missing (informational, not blocking)
Phase 3: Report
Present findings per file:
Spec Review: packages/cli/E2E_TESTS.md
==========================================
Structure: PASS (4 suites, 23 features)
Metadata: WARN (2 features missing category)
Quality: PASS
Issues:
WARNING Feature "Handle edge case" in suite "Task Creation" has no category comment
WARNING Feature "Process request" in suite "API" has no category comment
INFO Suite "Push" has no error-category features
INFO Suite "Init" has no idempotency-category features
Category distribution:
core: 14 features
edge: 3 features
error: 4 features
side-effect: 2 features
idempotency: 0 features ← consider adding
Summary: 2 warnings, 2 info notes
Do NOT modify the spec files. Report only.