Plan review tests

Plan Review Tests

Verify that the plan has enough test coverage.

Guardrails

• Start from success criteria and failure modes, then choose tests.
• Prefer the smallest test set that gives confidence for the changed behavior.
• Follow existing test framework and file placement before proposing new tooling.
• Do not require broad coverage unrelated to the plan.

Test Diagram

Create an ASCII diagram covering:

• New user-visible flows.
• New data flows.
• New codepaths.
• New branches, outcomes, and failure states.
• External integrations and mocked boundaries.

For each node, list the expected test type: unit, integration, end-to-end, contract, regression, visual, accessibility, load, or eval.

Coverage Review

Check:

• Happy paths.
• Nil, empty, invalid, and upstream-error paths.
• User interaction edge cases: double submit, slow network, navigation away, stale state, back/forward.
• Rollout and rollback behavior.
• Observability assertions where meaningful.
• Existing test conventions before recommending new framework or layout.

For LLM or prompt changes, inspect local project guidance such as AGENTS.md, CLAUDE.md, or .planning/* for eval patterns. If no eval guidance exists, recommend a small reference dataset and deterministic regression checks.

Artifact

Write a QA handoff to:

.planning/qa/test-plan-{branch}-{YYYYMMDD-HHMMSS}.md

Use this structure:

# Test Plan
Generated by /plan-eng-review on {date}
Branch: {branch}
Plan: {plan-path}

## Affected Pages/Routes
- {path} - {what to test and why}

## Key Interactions
- {interaction}

## Edge Cases
- {edge case}

## Critical Paths
- {flow}

## Non-UI Checks
- {command, endpoint, or behavior}

Output

Return the test diagram, missing tests, eval needs, and QA handoff path.

Install: npx skills add ChristopherAlphonse/calphonse-skills --skill plan-review-tests