agentsclimarketplace

Architecture review

Skill canstralian/rif-runtime/.claude/skills/architecture-review

Review proposed changes against the RIF Runtime architecture, invariants, dependency rules, and long-term evolution.From its SKILL.md

Install
npx -y skills add canstralian/rif-runtime --skill architecture-review

Assembled from the repository path, not quoted from the project. Check it against their README if it does not work.

One thing to look at

  • 1 stars1 stars. Stars are a popularity signal and not a quality one, but at this level it is likely that nobody has read this closely except its author, and you would be relying on your own review.

SKILL.md

2.7 KB, as published. Nobody here has run it

Architecture Review Skill

Mission

Review every proposed change for architectural correctness before implementation.

Optimize for long-term maintainability rather than local convenience.


Review Order

  1. Architecture
  2. Contracts
  3. Dependencies
  4. Determinism
  5. Maintainability
  6. Performance

Never optimize performance by violating architecture.


Runtime Spine

Resources ↓

Providers ↓

Knowledge ↓

Documentation

Execution ↓

Governance ↓

Evidence ↓

Replay

Every component belongs to exactly one subsystem.


Dependency Rules

Allowed

Resources → Providers

Providers → Knowledge

Knowledge → Documentation

Execution → Governance

Governance → Evidence

Evidence → Replay

Forbidden

Documentation → Knowledge

Providers → Resources

Replay → Governance

Resources → Documentation

Knowledge → Providers


Review Questions

For every proposed change ask:

• Which subsystem owns this?

• Does it introduce a new dependency?

• Can the dependency be inverted?

• Does it increase coupling?

• Does it preserve determinism?

• Does it require a new ADR?


Architecture Smells

Flag immediately:

  • circular imports
  • singleton abuse
  • mutable global state
  • duplicated contracts
  • hidden dependencies
  • undocumented invariants
  • provider-specific logic in resources
  • business logic in providers

Resource Rules

Resources describe state.

Resources never execute work.

Resources never call providers.

Resources are immutable.


Provider Rules

Providers perform interactions.

Providers never implement policy.

Providers expose stable contracts.


Knowledge Rules

Knowledge interprets snapshots.

Knowledge is reproducible.

Knowledge is derived.

Knowledge is never authoritative.


Documentation Rules

Documentation renders knowledge.

Documentation never replaces source truth.

Generated documentation must remain reproducible.


Governance Rules

Every effectful operation passes through Governance.

No bypasses.

No hidden writes.


Evidence Rules

Evidence is append-only.

Evidence records facts.

Evidence is immutable.


Replay Rules

Replay validates execution.

Replay never mutates history.


Required Outputs

Every review produces:

Architecture Summary

Dependency Impact

Risk Assessment

Suggested Improvements

ADR Recommendation (if required)


Success Criteria

Approve only changes that strengthen the architecture and preserve subsystem boundaries.

Reject shortcuts that create future maintenance debt.

Keep looking

Skills are one crate of 608,666. Ordering is by how many stacks a row turns up in, so the top of any crate is what has actually been picked rather than what has the most stars.