Review
Comprehensive code review of recent changes in the iam-policy-validator project. Use when the user wants a code review, quality check, or audit of recent changes. Triggers on "/review", "review my changes", "code review", or "check code quality".From its SKILL.md
npx -y skills add boogy/iam-policy-validator --skill reviewAssembled from the repository path, not quoted from the project. Check it against their README if it does not work.
One thing to look at
- 12 stars12 stars. Stars are a popularity signal and not a quality one, but at this level it is likely that nobody has read this closely except its author, and you would be relying on your own review.
SKILL.md
1.7 KB, as published. Nobody here has run it
Review
Perform a comprehensive code review of recent changes.
Workflow
1. Gather Changes
git status
git diff --name-only main...HEAD # branch-scoped (fall back to HEAD~N if not on a branch)
git log --oneline main..HEAD
Categorize modified files by type (check, command, core, tests, docs).
2. Review Against Project Standards
Python code: Type hints on public functions? Async patterns correct? Pydantic models proper? Error handling appropriate?
Checks (iam_validator/checks/): Inherits PolicyCheck? Has check_id, description, default_severity ClassVars? Uses self.get_severity(config)? Returns list[ValidationIssue]?
Tests: Uses @pytest.mark.asyncio? Mock fixtures for AWS calls? Both positive and negative cases? Config overrides tested?
Security: No secrets/credentials? No overly permissive file operations? Input validation present?
Documentation: CHANGELOG.md updated? CLAUDE.md files updated if structure changed? Commits signed?
3. Run Quality Checks
uv run ruff check iam_validator/
uv run mypy iam_validator/
uv run pytest -m "not benchmark and not slow"
4. Output Format
### Summary
- X files reviewed
- Y issues found (X critical, Y high, Z medium)
### Critical Issues
- [file:line] Description and fix
### High Issues
- [file:line] Description and fix
### Recommendations
- General improvements
### Tests
- Pass/fail status
- Coverage changes